Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing "cbor" feature flag on test #5321

Merged
merged 3 commits into from
May 9, 2024

Conversation

elton-cs
Copy link
Contributor

Description

Found a failing test while looking through the request-response protocol crate. The function dial_succeeds_after_adding_peers_address() was just missing the cbor feature flag. Added the flag and the test passed.

@elton-cs elton-cs changed the title Add missing "cbor" feature flag on test chore: add missing "cbor" feature flag on test Apr 19, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label May 9, 2024
@mergify mergify bot merged commit 0e11c61 into libp2p:master May 9, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants